-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE] Added areas to homeassistant_HassTurnOff and HassTurnOn #2163
Conversation
WalkthroughWalkthroughThe recent updates to the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files not reviewed due to errors (1)
Additional comments not posted (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SaftigeSteaks
many thanks for this contribution 👍
But we still need test sentences to ensure there are no regressions and your changes work, thx 👍
p.s.: I would suggest that you use a Codespace for this changes - this will run a full development environment online.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale. Feel free to re-open this PR when you are ready to pick up work on it again 👍 ../Frenck |
Now sentences like "Schalte den Computer im Wohnzimmer an" or "Mache im Wohnzimmer den Computer aus" will work
Summary by CodeRabbit
HassTurnOff
intent to support varied order of<name>
and<area>
parameters for more flexible commands.HassTurnOn
intent to include optionalarea
specifications, allowing more versatile device activation commands.