Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NL] Finetune cover_HassTurnOff/On and align with EN #2290

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TheFes
Copy link
Contributor

@TheFes TheFes commented Jul 8, 2024

changes:

  • Add support for area aware intents
  • Added some additional combinations by allowing different word order
  • Some cleanup

Differences with EN

  • Add support for floors
  • The curtain intents are split off from the other device classes. If I look at my own situation, I have blinds for the sun, and curtains on the same window. I do not always want to close both, the blinds are closed on sunny days, while the curtains are closed after the sun has set.

Summary by CodeRabbit

  • New Features

    • Added new expansion rule for "floor" and included "hier" as an option in generic expansion rules.
  • Enhancements

    • Refined sentence structures for the HassTurnOff and HassTurnOn intents to improve the handling and control of covers like garage doors, curtains, blinds, shutters, and shades.
  • Tests

    • Streamlined and enhanced test cases to cover new sentence variations for turning off and on various home devices.

Copy link

coderabbitai bot commented Jul 8, 2024

Walkthrough

Walkthrough

The updates involve additions and refinements in Dutch YAML files related to home automation commands. New expansion rules and sentence structures are introduced to enhance the flexibility and accuracy of commands for controlling covers, such as curtains, blinds, shutters, and shades. Test cases are also updated to reflect these changes, ensuring comprehensive coverage and standardization.

Changes

File Path Change Summary
sentences/nl/_common.yaml Added new expansion rules for "floor" and included "hier" in generic expansion rules.
sentences/nl/cover_HassTurnOff.yaml Refined expressions for closing covers, enhancing phrasing and slot specifications for closing various devices in specific areas.
sentences/nl/cover_HassTurnOn.yaml Modified sentence structures for opening covers, refining expressions for various cover-related actions.
tests/nl/cover_HassTurnOff.yaml Streamlined test cases by removing phrases and adding new variations for turning off devices in specific areas.
tests/nl/cover_HassTurnOn.yaml Adjusted test sentences for turning on home devices, simplifying and standardizing commands.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 04a8be4 and ae4002e.

Files selected for processing (5)
  • sentences/nl/_common.yaml (1 hunks)
  • sentences/nl/cover_HassTurnOff.yaml (2 hunks)
  • sentences/nl/cover_HassTurnOn.yaml (2 hunks)
  • tests/nl/cover_HassTurnOff.yaml (6 hunks)
  • tests/nl/cover_HassTurnOn.yaml (7 hunks)
Files skipped from review as they are similar to previous changes (5)
  • sentences/nl/_common.yaml
  • sentences/nl/cover_HassTurnOff.yaml
  • sentences/nl/cover_HassTurnOn.yaml
  • tests/nl/cover_HassTurnOff.yaml
  • tests/nl/cover_HassTurnOn.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@TheFes
Copy link
Contributor Author

TheFes commented Jul 8, 2024

@frenck
next one, the split between curtain and the other device classes was already in place for these sentences, I kept it in for the reason mentioned above. Does it make sense to also apply that to other languages?

@TheFes TheFes changed the title [NL] Finetune cover_HassTurnOn and align with EN [NL] Finetune cover_HassTurnOff/On and align with EN Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant