Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump aiohttp from 3.8.4 to 3.8.5 (#4448)" #4466

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Aug 1, 2023

This reverts commit b817841.

Proposed change

3.8.5 seems to have created a backwards compatibility issue, this update is the root cause of #4454 . Reverting until I can track down why.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Aug 1, 2023
@frenck
Copy link
Member

frenck commented Aug 1, 2023

Let's downgrade, ship it, upgrade and take time to find out what is going

@mdegat01 mdegat01 merged commit 45f930a into main Aug 1, 2023
23 checks passed
@mdegat01 mdegat01 deleted the revert-4448-dependabot/pip/aiohttp-3.8.5 branch August 1, 2023 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIOHTTP Error in Log for Supervisor 2023.07.2 {BETA}
2 participants