NodeJS versions in GitHub actions #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might as well add 20 at this point... https://github.com/actions/node-versions/releases |
cclauss
reviewed
Jun 10, 2023
.github/workflows/build.yml
Outdated
| @@ -9,7 +9,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| # the Node.js versions to build on | |||
| node-version: [12.x, 13.x, 14.x, 15.x, 16.x] | |||
| node-version: [14.x, 15.x, 16.x, 18.x] | |||
There was a problem hiding this comment.
Suggested change
| node-version: [14.x, 15.x, 16.x, 18.x] | |
| node-version: [16.x, 18.x, 20.x] |
cclauss
reviewed
Jun 10, 2023
README.md
Outdated
| @@ -24,7 +24,7 @@ Click the link below to create a new GitHub Repository using this template, or c | |||
|
|
|||
| ## Setup Development Environment | |||
|
|
|||
| To develop Homebridge plugins you must have Node.js 12 or later installed, and a modern code editor such as [VS Code](https://code.visualstudio.com/). This plugin template uses [TypeScript](https://www.typescriptlang.org/) to make development easier and comes with pre-configured settings for [VS Code](https://code.visualstudio.com/) and ESLint. If you are using VS Code install these extensions: | |||
| To develop Homebridge plugins you must have Node.js 14 or later installed, and a modern code editor such as [VS Code](https://code.visualstudio.com/). This plugin template uses [TypeScript](https://www.typescriptlang.org/) to make development easier and comes with pre-configured settings for [VS Code](https://code.visualstudio.com/) and ESLint. If you are using VS Code install these extensions: | |||
There was a problem hiding this comment.
Suggested change
| To develop Homebridge plugins you must have Node.js 14 or later installed, and a modern code editor such as [VS Code](https://code.visualstudio.com/). This plugin template uses [TypeScript](https://www.typescriptlang.org/) to make development easier and comes with pre-configured settings for [VS Code](https://code.visualstudio.com/) and ESLint. If you are using VS Code install these extensions: | |
| To develop Homebridge plugins you must have Node.js 16 or later installed, and a modern code editor such as [VS Code](https://code.visualstudio.com/). This plugin template uses [TypeScript](https://www.typescriptlang.org/) to make development easier and comes with pre-configured settings for [VS Code](https://code.visualstudio.com/) and ESLint. If you are using VS Code install these extensions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
For verification of homebridge plugin one must support the node LTS versions 14.x, 16.x and 18.x (see requirements). The GitHub actions template contains versions 12.x, 13.x, 14.x, 15.x, 16.x but not 18.x.
💡 Proposed solution
Version 18.x should be added to the actions as well.
Maybe 12.x, 13.x and 15.x could be removed as they are not mandatory?
⚙️ Release Notes
➕ Additional Information
See existing issue.
Testing
Reviewer Nudging