Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #56

Closed
wants to merge 3 commits into from
Closed

Upgrade GitHub Actions #56

wants to merge 3 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 20, 2023

https://github.com/nodejs/release#readme
https://github.com/actions/checkout/releases
https://github.com/actions/setup-node/releases
https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

CI Always set to true.

♻️ Current situation

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

💡 Proposed solution

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

⚙️ Release Notes

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

➕ Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

@@ -27,5 +27,3 @@ jobs:

- name: Build the project
run: npm run build
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this change do?

@bwp91
Copy link
Contributor

bwp91 commented Jul 21, 2023

Hi @cclauss looking into these PRs now, please rebase on main which i renamed from master

@bwp91
Copy link
Contributor

bwp91 commented Jul 22, 2023

Closing this as I don't believe is needed anymore, thanks for your contributions @cclauss

@bwp91 bwp91 closed this Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants