-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supports_reboot helper #486
Conversation
WalkthroughThe pull request introduces a new method Changes
Sequence DiagramsequenceDiagram
participant Device
participant APIVersion
Device->>APIVersion: Check major version
alt Major version >= 2
Device-->>Device: Return True (Supports Reboot)
else Major version < 2
Device-->>Device: Return False (No Reboot Support)
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 9 9
Lines 563 565 +2
Branches 41 41
=======================================
+ Hits 560 562 +2
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
SSIA
Summary by CodeRabbit
New Features
supports_reboot()
method to check device reboot support based on API versionDocumentation
supports_cloud_enable()
method to clarify its functionalityTests
supports_reboot()
method behavior for version 1 and version 2 devices