Fix: BlueSky expandos have issues on chromium browsers #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that most subreddits banned twitter posts, I have been seeing more bsky.app posts pop up and have made a few changes as I have been testing them, including improving handling of url recognition.
I have also added a little error message if the embed api returns an error, as that post does not support being embedded due to user settings on the site. Here is an example:
I also noticed that the embedded javascript only works in Firefox. I am now stripping the script out and there is currently no way to exclude the script tag via the API like the twitter modules does. I also made the styling match the twitter expando when you don't have a tampermonkey/greesemonkey script to include the embed.js manually.
Unfortunately, I cannot get the embedded javascript to work unless I have the mentioned greesemonkey script. Here's what I was using: https://greasyfork.org/en/scripts/525193-res-bluesky-expandos
Relevant issue: N/A
Tested in browser: Firefox, Brave/Chrome