Fix flaky TestRESTGet in ipgroupassociation (antrea-io#5031)

The test should wait for informers to sync once, instead of using a short sleep. The test was flaky on slower machines. Signed-off-by: Antonin Bas <[email protected]>
hongliangl · May 25, 2023 · 76c2f0e · 76c2f0e
1 parent 74b203a
commit 76c2f0e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/apiserver/registry/networkpolicy/ipgroupassociation/rest_test.go b/pkg/apiserver/registry/networkpolicy/ipgroupassociation/rest_test.go
@@ -299,9 +299,11 @@ func TestRESTGet(t *testing.T) {
 	eeInformer.Informer().AddIndexers(cache.Indexers{grouping.ExternalEntityIPsIndex: grouping.ExternalEntityIPsIndexFunc})
 
 	stopCh := make(chan struct{})
+	defer close(stopCh)
 	informerFactory.Start(stopCh)
 	crdInformerFactory.Start(stopCh)
-	time.Sleep(10 * time.Millisecond)
+	informerFactory.WaitForCacheSync(stopCh)
+	crdInformerFactory.WaitForCacheSync(stopCh)
 
 	rest := NewREST(podInformer, eeInformer, fakeIPBQuerier{ipGroupMap: ipGroups}, fakeQuerier{groups: groups})
 	for _, tt := range tests {