Skip to content

Commit

Permalink
Required Pexpect >=4.3
Browse files Browse the repository at this point in the history
Async was used as a keywor in previous versions.
Closes ipython#12507
  • Loading branch information
Carreau committed Aug 25, 2020
1 parent 102ca4f commit 9787b4d
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,19 +199,21 @@
# This is the correct way to specify these,
# but requires pip >= 6. pip < 6 ignores these.

extras_require.update({
':sys_platform != "win32"': ['pexpect'],
':sys_platform == "darwin"': ['appnope'],
':sys_platform == "win32"': ['colorama'],
})
extras_require.update(
{
':sys_platform != "win32"': ["pexpect>4.3"],
':sys_platform == "darwin"': ["appnope"],
':sys_platform == "win32"': ["colorama"],
}
)
# FIXME: re-specify above platform dependencies for pip < 6
# These would result in non-portable bdists.
if not any(arg.startswith('bdist') for arg in sys.argv):
if sys.platform == 'darwin':
install_requires.extend(['appnope'])

if not sys.platform.startswith('win'):
install_requires.append('pexpect')
if not sys.platform.startswith("win"):
install_requires.append("pexpect>4.3")

# workaround pypa/setuptools#147, where setuptools misspells
# platform_python_implementation as python_implementation
Expand Down

0 comments on commit 9787b4d

Please sign in to comment.