Merge pull request kubesphere#667 from wansir/fix-ldap-conn-pool

fix: recycle ldap connections in pool
hongzhouzi · Aug 27, 2019 · c6440ec · c6440ec
2 parents defaa63 + abc7423
commit c6440ec
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/models/iam/im.go b/pkg/models/iam/im.go
@@ -467,6 +467,8 @@ func GetUserInfo(username string) (*models.User, error) {
 		return nil, err
 	}
 
+	defer conn.Close()
+
 	userSearchRequest := ldap.NewSearchRequest(
 		ldapclient.UserSearchBase,
 		ldap.ScopeWholeSubtree, ldap.NeverDerefAliases, 0, 0, false,
@@ -1162,6 +1164,8 @@ func DescribeGroup(path string) (*models.Group, error) {
 		return nil, err
 	}
 
+	defer conn.Close()
+
 	groupSearchRequest := ldap.NewSearchRequest(searchBase,
 		ldap.ScopeSingleLevel, ldap.NeverDerefAliases, 0, 0, false,
 		fmt.Sprintf("(&(objectClass=posixGroup)(cn=%s))", cn),