refactor(pattern-router): reduce bundle size and remove outdated comm…

…ents (#3936)
honojs · Feb 21, 2025 · a2ec848 · a2ec848
1 parent c9bd830
commit a2ec848
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/router/pattern-router/router.ts b/src/router/pattern-router/router.ts
@@ -1,7 +1,7 @@
 import type { Params, Result, Router } from '../../router'
 import { METHOD_NAME_ALL, UnsupportedPathError } from '../../router'
 
-type Route<T> = [RegExp, string, T] // [pattern, method, handler, path]
+type Route<T> = [RegExp, string, T] // [pattern, method, handler]
 
 const emptyParams = Object.create(null)
 
@@ -30,13 +30,15 @@ export class PatternRouter<T> implements Router<T> {
       }
     )
 
-    let re
     try {
-      re = new RegExp(`^${parts.join('')}${endsWithWildcard ? '' : '/?$'}`)
+      this.#routes.push([
+        new RegExp(`^${parts.join('')}${endsWithWildcard ? '' : '/?$'}`),
+        method,
+        handler,
+      ])
     } catch {
       throw new UnsupportedPathError()
     }
-    this.#routes.push([re, method, handler])
   }
 
   match(method: string, path: string): Result<T> {