Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP refactor: make constructors as functions to reduce bundle size #3666

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yusukebe
Copy link
Member

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (bfc190f) to head (f98b1eb).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3666    +/-   ##
========================================
  Coverage   91.70%   91.71%            
========================================
  Files         159      160     +1     
  Lines       10159    10171    +12     
  Branches     2977     2853   -124     
========================================
+ Hits         9316     9328    +12     
  Misses        842      842            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yusukebe yusukebe force-pushed the refactor/constructors branch from f012f2e to 40ac8ce Compare November 15, 2024 09:05
@EdamAme-x
Copy link
Contributor

it works well.
image

This comment has been minimized.

Copy link

Bundle size check

main (bfc190f) #3666 (831f1ba) +/-
Bundle Size (B) 18,835B 18,756B -79B
Bundle Size (KB) 18.39K 18.32K -0.07K

Compiler Diagnostics

main (bfc190f) #3666 (831f1ba) +/-
Files 256 257 1
Lines 115,030 115,046 16
Identifiers 111,963 111,996 33
Symbols 243,452 243,475 23
Types 204,686 204,689 3
Instantiations 3,044,030 3,044,030 0
Memory used 420,634K 428,708K 8,074K
I/O read 0.02s 0.03s 0.01s
I/O write 0s 0s 0s
Parse time 0.74s 0.77s 0.03s
Bind time 0.27s 0.34s 0.07s
Check time 5.91s 5.62s -0.29s
Emit time 0s 0s 0s
Total time 6.93s 6.73s -0.2s

Reported by octocov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants