Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support TypeScript 5.7 for Deno 2.2 #3939

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Feb 20, 2025

Fixes #3935

To support TypeScript 5.7, which was introduced in Deno 2.2, I've fixed some things about ArrayBuffer.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

This comment has been minimized.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (5e1f54c) to head (5077df2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3939      +/-   ##
==========================================
+ Coverage   91.29%   91.32%   +0.03%     
==========================================
  Files         168      168              
  Lines       10770    10686      -84     
  Branches     3063     3063              
==========================================
- Hits         9832     9759      -73     
+ Misses        937      926      -11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member Author

Hey @EdamAme-x !

Can you review this?

@yusukebe yusukebe requested a review from EdamAme-x February 20, 2025 10:08
Copy link

Bundle size check

main (5e1f54c) #3939 (adc721d) +/-
Bundle Size (B) 18,958B 18,958B 0B
Bundle Size (KB) 18.51K 18.51K 0K

Compiler Diagnostics

main (5e1f54c) #3939 (adc721d) +/-
Files 261 261 0
Lines 116,442 116,442 0
Identifiers 114,436 114,436 0
Symbols 303,841 303,841 0
Types 214,827 214,827 0
Instantiations 3,091,598 3,091,598 0
Memory used 453,904K 454,551K 647K
I/O read 0.03s 0.03s 0s
I/O write 0s 0s 0s
Parse time 0.73s 0.7s -0.03s
Bind time 0.28s 0.3s 0.02s
Check time 5.5s 5.71s 0.21s
Emit time 0s 0s 0s
Total time 6.51s 6.71s 0.2s

Reported by octocov

Copy link
Contributor

@EdamAme-x EdamAme-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member Author

@EdamAme-x Thanks!

@yusukebe yusukebe merged commit c9bd830 into main Feb 21, 2025
16 checks passed
@yusukebe yusukebe deleted the refactor/support-typescript57 branch February 21, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: type error due to Deno version increase and typescript version update
2 participants