Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Bondsmith and Fiserv source verification #48

Merged
merged 2 commits into from
May 6, 2024

Conversation

alexluong
Copy link
Collaborator

@alexluong alexluong commented May 5, 2024

resolves #38

@alexluong alexluong marked this pull request as ready for review May 5, 2024 05:28
@leggetter
Copy link
Collaborator

@alexluong - could we also add #49 to this PR? The required functionality should be in the latest SDK.

@alexluong
Copy link
Collaborator Author

@leggetter certainly! I did mention it to you as well. There are a few more than just AWS Signature that we haven't supported tho. Should we add them as well?

In either case, any reason why we can't merge this and follow up on that later? They're separate enough that I don't see a strong reason why they should be in the same PR.

@leggetter
Copy link
Collaborator

@leggetter certainly! I did mention it to you as well. There are a few more than just AWS Signature that we haven't supported tho. Should we add them as well?

In either case, any reason why we can't merge this and follow up on that later? They're separate enough that I don't see a strong reason why they should be in the same PR.

@alexluong, the AWS Signature one is a priority, so it'd be great to see that one ASAP 🙏 But I'll merge this one as addressing verifications only.

@leggetter leggetter merged commit 408b42d into hookdeck:main May 6, 2024
7 checks passed
@alexluong
Copy link
Collaborator Author

@leggetter ah I see, noted on the priority of the AWS Signature and will work on that soon!

@alexbouchardd
Copy link
Contributor

@alexluong Could we also add a json bypass for the destination auth so that there's a workaround when more are added?

@alexluong alexluong deleted the add-source-verification branch May 6, 2024 13:51
@sidekick-eimantas
Copy link

Amazing work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to new Go SDK v0.3.8 and add new source and verification support
4 participants