Fix core too strongly bound to underlying nodes #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teebor-Choka
approved these changes
Jan 11, 2024
|
It'd be nice to see a more detailed description of the problem on the PR. |
It's still a draft and WIP. |
jeandemeusy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CT Core relies on nodes, more precisely on node's API's. In case a node get unreachable, a call to it's API will fail. This behaviour is expected, but needs some attention.
If a result of the API call is a dictionary, accessing the content of this dictionary needs to be done in a safe way.
This was done most of the time, but some remaining parts of the codes were still using API results without checking that the result is indeed available.
This PR fixes this issue (#459)