Prevent app from breaking when nodes are not reachable #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jeandemeusy
added
component:hoprd-api
Teebor-Choka
approved these changes
Mar 5, 2024
Co-authored-by: Tibor <[email protected]>
jeandemeusy
deleted the
jean/prevent-app-from-breaking-when-node-not-reachable
branch
jeandemeusy
added a commit
that referenced
this pull request
Apr 15, 2024
* more logs for api, removed color, added back timestamp * Migrate hoprd nodes to GCP (#477) * Migrate hoprd nodes to GCP * remove parameter * apply changes * scale up * bump helm chart * upgrade helm chart version * Prevent app from breaking when nodes are not reachable (#479) * added timeout on api calls * ensured all api calls are behind "connectguard" decorator * fix timeout * Catching any other exception from API * func renamed * node address access thread safe * ensure timeout it used on any http post request * Update ct-app/core/core.py Co-authored-by: Tibor <[email protected]> --------- Co-authored-by: Tibor <[email protected]> * Upgrade to 2.0.8 * scale down * scale first * scale up * scale up * fix (#481) * fix (#482) * Jean/kwargs and timeout mismatch in api (#483) * fix * timeout hardcoded * Use flake nix, only devShell (#485) * setup nix, fixed the list of parameters script * ci using nix ? * unified requirements files * fix after merge * adapt to new waitlist * update requirements for waitlist update --------- Co-authored-by: ausias-armesto <[email protected]> Co-authored-by: Tibor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, any API call is wrapped within a timeout-handler, so that the call cancels should it take too long (> 60s). Also ensured that all api calls are protected by the
@connectguarddecorator, which prevents an asyncio task to run if the node is not reachable.Solves #480