Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy production #503

Merged
merged 25 commits into from
Apr 30, 2024
Merged

Deploy production #503

merged 25 commits into from
Apr 30, 2024

Conversation

ausias-armesto
Copy link
Contributor

@ausias-armesto ausias-armesto commented Apr 29, 2024

Change the specific parameters to deploy in production:

  • Some changes needed to be done specifically for production.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced monitoring for the ctdapp service with a new ServiceMonitor resource.
    • Added backup URLs for staking and transactions, enhancing data redundancy.
    • Added a new secret key for enhanced security integration.
  • Enhancements

    • Increased the concurrency level for the Postman application, improving performance.
    • Updated service naming and labeling for clearer identification and management.
  • Configuration Changes

    • Adjusted configurations and environment variables for better service tuning.
    • Removed outdated configuration parameters to streamline operations.
  • Bug Fixes

    • Corrected a typo in a key within the secret configuration.

@ausias-armesto ausias-armesto self-assigned this Apr 29, 2024
@ausias-armesto ausias-armesto added the devops Task that require devops support label Apr 29, 2024
@ausias-armesto ausias-armesto linked an issue Apr 29, 2024 that may be closed by this pull request
@hoprnet hoprnet deleted a comment from coderabbitai bot Apr 29, 2024
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

The recent updates to the ctdapp Helm charts involve significant configuration changes, including the adjustment of environment variables, service monitoring enhancements, and deployment settings. These modifications aim to refine the application's functionality and monitoring capabilities, ensuring better performance and reliability.

Changes

Files Summary
configmap-core.yaml, configmap-postman.yaml Removed various configuration parameters; added conditional blocks for extra environment variables.
configmap-nodes.yaml Corrected node URLs and added a new entry.
deployment-postman.yaml Adjusted Celery worker concurrency level from 4 to 5.
secret-nodes.yaml, secret-subgraph.yaml Added new entries, backup URLs, and corrected a typo.
service-monitor.yaml Introduced a ServiceMonitor resource for ctdapp.
service.yaml Modified service name and added new labels.
secrets-prod.sops.yaml Updated encrypted URLs and modified timestamps.
values-common.yaml Removed schedule attribute under funding.
values-prod.yaml Adjusted replicas count and added environment variables for ctdapp services.
values-prod-blue.yaml, values-prod-green.yaml Added identityPool section with funding details.
values-staging-blue.yaml, values-staging-green.yaml Added identityPool section with funding details and updated configurations for identities.

🐇✨
In the land of code and helm,
Changes big and small overwhelm.
ConfigMaps dance, secrets align,
A rabbit's touch, making all fine.
Hop, hop, hop, to the future we leap,
With cleaner code, the benefits we reap! 🌟
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fc18066 and bc312f7.
Files selected for processing (6)
  • helm/ctdapp/templates/configmap-nodes.yaml (1 hunks)
  • helm/values-common.yaml (1 hunks)
  • helm/values-prod-blue.yaml (1 hunks)
  • helm/values-prod-green.yaml (1 hunks)
  • helm/values-staging-blue.yaml (1 hunks)
  • helm/values-staging-green.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • helm/ctdapp/templates/configmap-nodes.yaml
Additional comments not posted (7)
helm/values-common.yaml (1)

Line range hint 15-18: Removal of the schedule attribute simplifies the identityPool configuration.

helm/values-prod-green.yaml (1)

15-18: Addition of the schedule field under funding in the identityPool section introduces flexibility in managing funding schedules.

helm/values-prod-blue.yaml (2)

15-18: Addition of the schedule field under funding in the identityPool section introduces flexibility in managing funding schedules.


18-18: Ensure the updated configuration for ctdapp-blue-node-1 is secure and aligns with deployment requirements.

helm/values-staging-green.yaml (2)

15-18: Addition of the schedule field under funding in the identityPool section introduces flexibility in managing funding schedules.


18-18: Ensure the updated configuration for ctdapp-green-node-1 is secure and aligns with deployment requirements.

helm/values-staging-blue.yaml (1)

15-18: Addition of the schedule field under funding in the identityPool section introduces flexibility in managing funding schedules.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ausias-armesto ausias-armesto merged commit fa0a481 into main Apr 30, 2024
2 checks passed
@jeandemeusy jeandemeusy deleted the ausias/deploy-production branch April 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Task that require devops support status:done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Ctdapp to a new GCP project
2 participants