Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deployment's helm files #505

Merged
merged 30 commits into from
May 3, 2024
Merged

Conversation

jeandemeusy
Copy link
Collaborator

@jeandemeusy jeandemeusy commented Apr 30, 2024

Cleaned-up the deployment files.
The common values between staging and production have been set as such. Specific staging parameter also, except for some secrets that needs to be done.
Also changed the tag structure to be next to replicaCount and envParameters for each module.

Summary by CodeRabbit

  • New Features

    • Enhanced core configurations including health checks, subgraph operations, and economic models.
    • Improved node operations settings for better channel management and peer interactions.
    • New environment variables for message handling efficiency in Postman component.
  • Enhancements

    • Updated Kubernetes deployment configurations for core and Postman containers to use refined image repository references.
    • Simplified the structure of configuration files by restructuring image properties.
  • Bug Fixes

    • Adjusted environment variables and settings in production configurations to align with operational requirements.
  • Documentation

    • Updated comments and documentation in configuration files to reflect recent changes and additions.

Copy link
Contributor

coderabbitai bot commented Apr 30, 2024

Walkthrough

Walkthrough

The updates across various Helm configuration files for ctdapp mainly involve adding new configurations and environment variables, restructuring existing ones, and updating image references. These changes enhance core functionalities, improve node operations, and refine the deployment process for both production and staging environments.

Changes

Files Change Summary
helm/ctdapp/templates/configmap-core.yaml, helm/ctdapp/templates/configmap-postman.yaml Added various new configurations and environment variables related to core functionalities, node operations, distribution settings, peer versions, GCP configurations, economic models, and RabbitMQ details.
helm/ctdapp/templates/deployment-core.yaml, helm/ctdapp/templates/deployment-postman.yaml Updated image repository and pull policy references for core and Postman containers in Kubernetes deployment configurations.
helm/ctdapp/values.yaml, helm/values-prod.yaml Restructured image properties by moving them directly under core and postman, adjusted environment variables for core components, and modified values like DISTRIBUTION_MIN_ELIGIBLE_PEERS, DISTRIBUTION_MAX_APR_PERCENTAGE, GCP_BUCKET, and CHANNEL_MIN_BALANCE.
helm/secrets-staging.sops.yaml Updated subgraph section with new comments and modifications to URL values like safesBalanceUrl, stakingUrl, and wxhoprTxsUrl, along with updating lastmodified and mac values.

🐇✨
In the land of code and helm,
A rabbit hopped with a new realm.
Flags and vars, in files they dwell,
Changes made, with tales to tell.
Hop, skip, deploy, all's well! 🌟
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 97cc97b and 102497c.
Files selected for processing (1)
  • helm/ctdapp/values.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • helm/ctdapp/values.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jeandemeusy jeandemeusy marked this pull request as ready for review April 30, 2024 17:34
@jeandemeusy jeandemeusy merged commit 5f745a3 into main May 3, 2024
2 checks passed
@jeandemeusy jeandemeusy deleted the jean/clean-up-deployment branch May 3, 2024 12:03
jeandemeusy added a commit that referenced this pull request May 21, 2024
commit bf07f1c
Author: Jean Demeusy <[email protected]>
Date:   Tue May 21 11:51:38 2024 +0200

    Fix catch provider error gql (#519)

commit 71f6003
Author: Jean Demeusy <[email protected]>
Date:   Mon May 20 23:01:23 2024 +0200

    chore: Handle additional error cases in GraphQLProvider (#518)

commit 65da931
Author: ausias-armesto <[email protected]>
Date:   Thu May 16 15:02:20 2024 +0200

    Add documentation on how to connect to database (#517)

    * Add documentation on how to connect to database

    * Update helm/README.md

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

    ---------

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

commit e1b4c0c
Author: ausias-armesto <[email protected]>
Date:   Tue May 14 21:54:20 2024 +0200

    Create automatic database backups (#516)

    * Create automatic database backups

    * remove character

    * rename backup

commit 61357f9
Author: ausias-armesto <[email protected]>
Date:   Mon May 13 18:06:06 2024 +0200

    Upgrade to version "saint-louis" (#515)

commit 930e8a5
Author: ausias-armesto <[email protected]>
Date:   Wed May 8 14:39:04 2024 +0200

    Upgrade clusterhoprd helm chart (#514)

    * Upgrade to make it work for new version of hoprd-operator

    * Upgrade version

commit f61036e
Author: ausias-armesto <[email protected]>
Date:   Wed May 8 14:32:16 2024 +0200

    Upgrade to make it work for new version of hoprd-operator (#513)

commit c28dc2a
Author: ausias-armesto <[email protected]>
Date:   Fri May 3 16:15:48 2024 +0200

    Fix typo in namespace (#511)

commit 59c6905
Author: ausias-armesto <[email protected]>
Date:   Fri May 3 16:10:30 2024 +0200

    Move the repository into the correct child (#510)

    * Move the repository into the correct child

    * Fixing secret rabbitMQ

commit 91307e1
Author: Jean Demeusy <[email protected]>
Date:   Fri May 3 15:35:24 2024 +0200

    Update Docker image repository URLs in values.yaml (#509)

commit 711b2a9
Author: ausias-armesto <[email protected]>
Date:   Fri May 3 14:55:35 2024 +0200

    Fixing pipeline tagging (#508)

commit b2d4773
Author: ausias-armesto <[email protected]>
Date:   Fri May 3 14:30:15 2024 +0200

    Using latest

commit 5f745a3
Author: Jean Demeusy <[email protected]>
Date:   Fri May 3 13:53:36 2024 +0200

    Clean up deployment's helm files (#505)

    * Scale deployment

    * fix

    * Adding envVars

    * quote

    * scale down

    * changing properties

    * updated prod env variables

    * deploy core and postman

    * change bucket name

    * Upgrading

    * fix url

    * add url x

    * adding secret x

    * new metrics

    * changing

    * update safe secrets

    * increase concurrency to 5

    * pointing to instance 0 of the RabbitMQ

    * fix pod name

    * change to static IP

    * updated to correct url

    * revert

    * Distributing auto-funding across different time-zones

    * Update configuration values for ctdapp in staging environment and default values

    * Update configuration values for ctdapp in staging environment and default values

    * Secrets updated

    ---------

    Co-authored-by: ausias-armesto <[email protected]>

commit fdd223c
Author: Jean Demeusy <[email protected]>
Date:   Fri May 3 13:49:24 2024 +0200

    Update Docker image repository URLs (#506)

    * Update Docker image repository URLs in values.yaml

    * Update workflows

    * Updating tag

    ---------

    Co-authored-by: ausias-armesto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants