Fix version parsing when returned value is UNKNOWN

[jeandemeusy]

Summary by CodeRabbit

• Bug Fixes
  • Improved the robustness of version handling by ensuring non-Version inputs are converted to Version objects, defaulting to "0.0.0" if conversion fails.

[coderabbitai]

Walkthrough

The recent changes in the peer.py file, located in the ct-app/core/model directory, involve enhancing the setter method for the version property in the Peer class. The update ensures that any non-Version input is converted to a Version object, defaulting to "0.0.0" if the conversion fails, thereby improving robustness and error handling.

Changes

File Path	Change Summary
ct-app/core/model/peer.py	Modified the version setter method in the Peer class to handle non-Version inputs more robustly.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Client
    participant Peer
    participant Version

    Client->>Peer: Set version with value (str or Version)
    Peer->>Peer: Check if value is instance of Version
    alt value is not Version
        Peer->>Version: Attempt to convert value to Version
        alt Conversion fails
            Peer->>Peer: Set version to default "0.0.0"
        else Conversion succeeds
            Peer->>Peer: Set version to converted value
        end
    else value is Version
        Peer->>Peer: Set version to value
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 87077f3 and 1065707.

Files selected for processing (1)

• ct-app/core/model/peer.py (1 hunks)

Additional Context Used

Ruff (1)

ct-app/core/model/peer.py (1)

52-52: Do not use bare except

GitHub Check Runs (1)

Lint and test code failure (3)

ct-app/core/model/peer.py: [failure] 52-52: Ruff (E722)
core/model/peer.py:52:13: E722 Do not use bare except

not relevant anymore

[jeandemeusy]

@coderabbitai review

[coderabbitai]

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1065707 and 082a9c6.

Files selected for processing (1)

• ct-app/core/model/peer.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• ct-app/core/model/peer.py