add node links #21
Open
add node links #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prototype/proposal patch implementing functionality discussed in issue hoptical#20 for adding optional links (external and internal) to graph nodes ## External Links - link__url, link__title ## Internal Links - link__expr, link__uid, link__name
|
@hoptical any suggestions or feedback? Thanks in advance! |
|
@lmangani Thanks for your contribution and sorry for being very late in sending my feedback. I had a terrible internet connection in my country for months and couldn't investigate further steps of this repo. BTW, I reviewed your branch and tried to get a run and check if I can see the links or context menu in the graph layout. The context menu wasn't shown yet and the problem was there. Maybe my input JSON wasn't correct. Would you please send a full sample of the JSON served to the plugin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prototype/proposal patch implementing functionality discussed in issue #20 for adding optional links (external and internal) to graph nodes. Link parameters format is similar to the
details__field:External Links
link__id__url,link__id__titleInternal Links
link__id__expr,link__id__uid,link__id__name,link__id__titleFormat Sample
{ "id": "1", "title": "Service1", "subTitle": "instance:#2", "detail__role": "load", "arc__failed": 0.7, "arc__passed": 0.3, "mainStat": "qaz", "link__external__url": "http://some/service", "link__external__title": "custom link", "link__internal__expr": "rate(traces_service_graph_request_total{server=\"${__data.fields.id}\"}[$__interval])", "link__internal__title": "request rate", "link__internal__uid": "prometheus" }