-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the reference paper for the SAC #268
base: master
Are you sure you want to change the base?
Conversation
can someone review this ? thanks @ankuriitg @HeartSaVioR |
I'm sorry, but I'm not sure we can link the paper which requires account to view. (meaning pay to view) I'm not sure you could make this being public. If possible, please change it and request again. |
Thanks for updating. As I guided here #260 as well, we're working with legal team to formalize contribution guide with ICLA/CCLA on this project to receive contributions outside of Cloudera. Thanks for the patience. |
README.md
Outdated
@@ -111,6 +111,10 @@ When running on cluster node, you will also need to distribute this keytab, belo | |||
|
|||
When Spark application is started, it will transparently track the execution plan of submitted SQL/DF transformations, parse the plan and create related entities in Atlas. | |||
|
|||
Reference | |||
=== | |||
- Mingjie Tang, Saisai Shao, Weiqing Yang, Yanbo Liang, Yongyang Yu, Bikas Saha, Dongjoon Hyun. [SAC: A System for Big Data Lineage Tracking](http://merlintang.github.io/paper/sac_icde.pdf). In IEEE 35th International Conference on Data Engineering (ICDE), 2019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than referring an individual github link why not just have the pdf as a part of the SAC repo itself?
Instead of a separate section we could just have it listed under the "Spark Atlas Connector" section in the README. Just a line as below with the link.
SAC: A System for Big Data Lineage Tracking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't include anything unless it's safe to claim that it's under copyright of Cloudera, or the license of paper is clear to be compatible with Apache License V2. Even it is compatible, we need to explicitly mention it to LICENSE. So why not just link it to avoid dealing with any license issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I meant link to external would be OK unless restricted. It's a different story if we "include" the paper in repo as a part of content, so I pointed out for that.
It is great that we can put the paper into the SAC directory. I think the
reference session is easier to follow.
Because of the ICLA/CCLA issue, can Arun to contribute this PR? I think
this publication is good for SAC to be known by others. I can close this.
…On Tue, Jun 25, 2019 at 4:37 PM Arun Mahadevan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#268 (comment)>
:
> @@ -111,6 +111,10 @@ When running on cluster node, you will also need to distribute this keytab, belo
When Spark application is started, it will transparently track the execution plan of submitted SQL/DF transformations, parse the plan and create related entities in Atlas.
+Reference
+===
+- Mingjie Tang, Saisai Shao, Weiqing Yang, Yanbo Liang, Yongyang Yu, Bikas Saha, Dongjoon Hyun. [SAC: A System for Big Data Lineage Tracking](http://merlintang.github.io/paper/sac_icde.pdf). In IEEE 35th International Conference on Data Engineering (ICDE), 2019
Rather than referring an individual github link why not just have the pdf
as a part of the SAC repo itself?
Instead of a separate section we could just have it listed under the
"Spark Atlas Connector" section in the README. Just a line as below with
the link.
SAC: A System for Big Data Lineage Tracking <http://url>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#268?email_source=notifications&email_token=AAK5R6PORKMLRHKCITRWKFLP4KT35A5CNFSM4H3LH5B2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4UKH6A#pullrequestreview-254321656>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAK5R6INJYVTNBZRN6AA2E3P4KT35ANCNFSM4H3LH5BQ>
.
|
Of course, I can remove the paper link, and just leave the paper name here?
is it ok ?
…On Tue, Jun 25, 2019 at 5:31 PM Jungtaek Lim ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#268 (comment)>
:
> @@ -111,6 +111,10 @@ When running on cluster node, you will also need to distribute this keytab, belo
When Spark application is started, it will transparently track the execution plan of submitted SQL/DF transformations, parse the plan and create related entities in Atlas.
+Reference
+===
+- Mingjie Tang, Saisai Shao, Weiqing Yang, Yanbo Liang, Yongyang Yu, Bikas Saha, Dongjoon Hyun. [SAC: A System for Big Data Lineage Tracking](http://merlintang.github.io/paper/sac_icde.pdf). In IEEE 35th International Conference on Data Engineering (ICDE), 2019
I wouldn't include anything unless it's safe to claim that it's under
copyright of Cloudera, or the license of paper is clear to be compatible
with ASF.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#268?email_source=notifications&email_token=AAK5R6JQBLBYGX5UVDDXZM3P4K2FFA5CNFSM4H3LH5B2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4UNDCA#discussion_r297444788>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAK5R6JWGZ6XITYAVG65BJ3P4K2FFANCNFSM4H3LH5BQ>
.
|
What changes were proposed in this pull request?
Update the SAC reference paper in the readme.
How was this patch tested?
No test is needed.