return null with pathConfiguredFailedToParse exception #91
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
reviewed
Jan 27, 2025
Comment on lines
-70
to
+72
| null | ||
| fun load(json: String): PathConfiguration? { | ||
| return try { | ||
| json.toObject(object : TypeToken<PathConfiguration>() {}) | ||
| } catch (e: Exception) { | ||
| logError("pathConfiguredFailedToParse", e) | ||
| null | ||
| } |
There was a problem hiding this comment.
This doesn't actually change any logic here. In Kotlin, = try is just shorthand for return try. Looking at this closer, we're already catching parsing exceptions correctly, just with a slightly different implementation from turbo-android.
There was a problem hiding this comment.
Yes, that's what I noticed when I started this. I meant to look into it further, but I became busy with work.
Thanks for coming back to it.
Comment on lines
+56
to
+68
| @Test | ||
| fun getMalformedRemoteConfiguration() { | ||
| enqueueResponse("malformed-body.json") | ||
| val loader = PathConfigurationLoader(context) | ||
|
|
||
| runBlocking { | ||
| launch(Dispatchers.Main) { | ||
| val json = repository.getRemoteConfiguration(baseUrl()) | ||
| val pathConfiguration = json?.let { loader.load(it) } | ||
| assertThat(pathConfiguration).isNull() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The more appropriate place for this test is in PathConfigurationTest, since parsing exceptions are caught at the PathConfigurationLoader layer, not the repository layer.
|
Tests were added here: #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was exploring the codebase, I noticed this issue and changed the return value to null in the case of an exception on parsing malformed json.