server driven navigation without path configuration #74
+31
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #71, which proposed adding support for server-driven routes like
/recede_historical_location
,/resume_historical_location
, and/refresh_historical_location
. These routes are designed to handle navigation stack behaviors (pop, refresh, or no-op) based on directives from the server.Implementation Overview
I've introduced a new extension to the NavigationHierarchyController class to handle these historical location routes. Key changes include:
Route Handling:
recede_historical_location
: Pops the current view or dismisses a modal.resume_historical_location
: No-op (does nothing).refresh_historical_location
: Refreshes the current view via a VisitProposal.Route Detection:
Added an
isHistoricalLocation(_:)
helper method to determine if a given URL matches one of the_historical_location
patterns.Routing Logic:
Updated
route(controller:proposal:)
to check for historical location routes before falling back to default routing logic.Goals of This PR
Notes:
I will be adding tests in the coming days - just wanted to see what the initial reaction might be.