Skip to content

Commit

Permalink
Upgrade playwright to 1.46.1
Browse files Browse the repository at this point in the history
It upgrades it in package.json and in the devcontainer
setup. It's now set to a specific version because it
needs to exactly match the playwright version which is
declared in the devcontainer setup.

The upgrade had to raise the node requirement to >= 18
because @playwright/test requires it.
  • Loading branch information
radanskoric committed Aug 26, 2024
1 parent 4d65288 commit 5c03d46
Show file tree
Hide file tree
Showing 6 changed files with 243 additions and 34 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# See comments in devcontainer.json for details of setting the playwright tag.
ARG PLAYWRIGHT_TAG="v1.30.0-focal"
ARG PLAYWRIGHT_TAG="v1.46.1-focal"
FROM mcr.microsoft.com/playwright:${PLAYWRIGHT_TAG}

WORKDIR /app
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
//
// pick '...-arm64' version if running on Apple Silicon.
"args": {
"PLAYWRIGHT_TAG": "v1.30.0-focal"
"PLAYWRIGHT_TAG": "v1.46.1-focal"
}
},
// Add the IDs of extensions you want installed when the container is created.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn run playwright install --with-deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'
cache: 'yarn'

- run: yarn install --frozen-lockfile
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
},
"devDependencies": {
"@open-wc/testing": "^3.1.7",
"@playwright/test": "~1.30.0",
"@playwright/test": "1.46.1",
"@rollup/plugin-node-resolve": "13.1.3",
"@web/dev-server-esbuild": "^0.3.3",
"@web/test-runner": "^0.15.0",
"@web/test-runner-playwright": "^0.9.0",
"@web/test-runner-playwright": "^0.11.0",
"arg": "^5.0.1",
"body-parser": "^1.20.1",
"chai": "~4.3.4",
Expand All @@ -63,6 +63,6 @@
"lint": "eslint . --ext .js"
},
"engines": {
"node": ">= 14"
"node": ">= 18"
}
}
Loading

0 comments on commit 5c03d46

Please sign in to comment.