Protect against abuse by unit tests

hpc · Feb 6, 2025 · ef0841b · ef0841b
1 parent b00372a
commit ef0841b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/lib/pavilion/test_run/test_run.py b/lib/pavilion/test_run/test_run.py
@@ -875,7 +875,14 @@ def _finalize_complete_file(self, complete_path: Path, complete_tmp_path: Path,
                                 "back on symlink to temporary file location.")
 
                 # Symlink with the expectation that the temp file will be there eventually
-                complete_path.symlink_to(complete_tmp_path)
+                try:
+                    complete_path.symlink_to(complete_tmp_path)
+                except FileExistsError:
+                    # This shouldn't happen during regular use, but happens during at least one
+                    # unit test, so we still need to handle it.
+                    status.set(STATES.WARNING, f"File {self.COMPLETE_FN} already exists. Test "
+                                                "appears to have been marked complete more than "
+                                                "once.")
 
         self._complete = True