Google Bar, Scatter and Line cant be "required" twice on a page

[jbrundage]

http://rawgit.com/hpcc-systems/Visualization/candidate-1.8.0/demos/dermatology.html?src/google/Bar

Go to the above link and toggle S. Test to see that it doesn't load the second instance of src/google/Bar

[mzummo]

it will load 3rd and 4th though it seems

[mzummo]

@GordonSmith can be tested via dermatology run serialization test and it wont run ... and then unclick and click again and it will run everytime after that .... is there a problem with the requirejs goog plugin?

[mzummo]

only effects new 1.1 version of google visualization i believe

[mzummo]

wasnt able to reproduce outside of VIZ ... something to do with our dataFactories and anonymous functions ... and only happens after loading google visualization 1.1

[mzummo]

Mismatched anonymous define() module:

[mzummo]

if ( typeof define === "function" && define.amd && define.amd.jQuery ) {
define( "jquery", [], function () { return jQuery; } );
}

using a named module above i dont know how that works (cant get it working) ... but maybe that might fix it?

[jbrundage]

@GordonSmith This is currently causing Travis CI to fail

[GordonSmith]

@jbrundage @mlzummo Nothing obvious I can spot (but I can reproduce) - the material charts are still in beta, so we may have no control over it (who issued this PR - did you know they were still beta?)

[mzummo]

@GordonSmith I am not 100% sure but i dont think the issue is 100% google as i can only reproduce the issue when using the new DataFactory (so far that is)

[dtsnell4]

I issued and I did not realize. #927

[dtsnell4]

Should we revert back to old version and forgo dual y axis for now?

[mzummo]

@dtsnell4 is there any reason we can't revert or did the new version provide a feature we needed?

[GordonSmith]

@jbrundage @mlzummo @dtsnell4 I think it may just be a async loading issue and that Line 1.1 needs corechart to be loaded first - investigating...

[mzummo]

its no longer happening in dermatology

[jbrundage]

It's occasionally still happening in dermatology

[GordonSmith]

well it was nice that travis was catching it (even with the d3-cloud issue).

[mzummo]

https://gist.github.com/Integralist/1599546 take a look at this

[mzummo]

http://stackoverflow.com/questions/18332748/how-to-handle-requirejs-timeout-error

[mzummo]

millermedeiros/requirejs-plugins#45

[mzummo]

http://techblog.realestate.com.au/loading-google-maps-with-requirejs/

[mzummo]

i think i know how to fix this but its going to require a pretty big refactor.

@GordonSmith perhaps after i explain you can help figure out a way to minimize the code required?

[mzummo]

    define(["d3", "../common/HTMLWidget", "async!http://www.google.com/jsapi"], factory);

...
google.load("visualization", 1.1, {"packages":["bar"]});
google.setOnLoadCallback(drawChart);
context._chart = new google.charts.Bar(domNode);

@GordonSmith

[GordonSmith]

That is effectively what goog! does: https://github.com/GordonSmith/requirejs-plugins/blob/master/src/goog.js

[mzummo]

nts: perhaps looks at r.js?