GH-995 RequireJS + Google Material Charts #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - Material charts are still "broken" in IE, but due to a different issue: google/google-visualization-issues#2039 |
|
Further: These material charts are still really buggy... |
Hack to work around google webfont issue: typekit/webfontloader#278 Fixes hpcc-systemsGH-995 Signed-off-by: Gordon Smith <[email protected]>
|
That's pretty clever and it seems to be working fine... but if its hacky and buggy, do we really want to include it in the library at this point? (material charts in general that is) |
|
Dunno - we might want a different grouping for the material charts anyway (rather than replacing the existing ones) - but it might just be there Bar chart is poor and things like the Gantt chart might be ok? |
|
looks good to me |
GordonSmith
added a commit
that referenced
this pull request
Dec 17, 2015
GH-995 RequireJS + Google Material Charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack to work around google webfont issue: typekit/webfontloader#278
Fixes GH-995
Signed-off-by: Gordon Smith [email protected]