Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 55 group #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix 55 group #58

wants to merge 3 commits into from

Conversation

xenlo
Copy link

@xenlo xenlo commented Oct 13, 2022

Fixing the 3 issues found with the following argument:

  • alarms_enabled (which was wrongly named in alarms)
  • alert_from_email_addr (which has a typo with an extra 's' at the end)
  • smtp_server (which was simply missing, not implemented)

Plus, move smtp_port argument to respect alphabetic sort

@xenlo
Copy link
Author

xenlo commented Dec 8, 2022

Try to reach HPe to request a review, as we have a valid support contract for our storage. Here is HPe support answer:

Hello Laurent,
As previously mentioned, the nimble-ansible-modules project is not currently an actively maintained project. As such, there are no engineers assigned to it, and no PRs are currently being processed.
However, I have relayed your request, and there is a potential that the status could be reconsidered in the coming weeks.
I will go ahead and archive this case, for the time being. The suggestion is to keep an eye out for possible work on this project in the coming weeks.
Kind Regards,

So, only to do is 🤞.

@datamattsson
Copy link
Collaborator

@xenlo we're trying to assign resources to maintain this project, I just think we need a bit more patience.

@sijeesh
Copy link
Collaborator

sijeesh commented Dec 15, 2022

@xenlo , Thank you for your PR. DCO check is failed, please work on it and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants