core: let ensureVisible also consider other scrollpanes

hpi-swa · Sep 22, 2023 · 5db6f00 · 5db6f00
1 parent 5505b26
commit 5db6f00
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/Sandblocks-Core/SBBlock.class.st b/packages/Sandblocks-Core/SBBlock.class.st
@@ -1175,8 +1175,17 @@ SBBlock >> ensureVisible [
 	method := self containingArtefact.
 	(method ~= self and: [method notNil and: [self visibleInWorld not]]) ifTrue: [method ensureExpanded].
 
-	self isInWorld ifTrue: [self sandblockEditor ifNotNil: [:e |
-		e scrollToShow: (e cursor cursorPosition block = self ifTrue: [e cursor cursorPosition] ifFalse: [self])]]
+	self isInWorld ifTrue: [ | show |
+		show := self fullBounds.
+		self allOwnersDo: [:o |
+			(o isKindOf: ScrollPane) ifTrue: [
+				o scrollToShow: show.
+				show := o fullBounds]].
+
+		self sandblockEditor ifNotNil: [:e |
+			e scrollToShow: (e cursor cursorPosition block = self
+				ifTrue: [e cursor cursorPosition]
+				ifFalse: [self])]]
 ]
 
 { #category : #actions }

diff --git a/packages/Sandblocks-Morphs/SBButton.class.st b/packages/Sandblocks-Morphs/SBButton.class.st
@@ -134,6 +134,12 @@ SBButton >> hovered: aBoolean [
 	self changed
 ]
 
+{ #category : #initialization }
+SBButton >> icon: anIconMorph do: aBlock [
+
+	self widget: anIconMorph shortcut: nil do: aBlock
+]
+
 { #category : #initialization }
 SBButton >> icon: anIconMorph label: aString do: aBlock [