Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tf+ 35 email notifications #277

Merged
merged 27 commits into from
Jan 24, 2023
Merged

Conversation

jacob271
Copy link
Collaborator

@jacob271 jacob271 commented Jan 16, 2023

Fixes #35

This PR implements e-mail notifications for all notifications with a call to action (those listed in #35).

Further notes

  • For the dev and test environment we used letter_opener which is a gem to mock e-mails. Instead of sending real emails, another tab opens with the content of the mail
  • We use SendGrid since it allows us to scale email notifications easily (the free tier allows for up to 100 emails/day)
  • @rgwohlbold will add a secret to the deployment which includes the ApiKey for SendGrid. The secret is then used in the deploy workflows
  • After merging this PR, we should check if everything works as intended on the dev deployment

PR checklist

  • dev-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • localization is supported (Guide)
  • another dev reviewed and approved
  • if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

@jacob271 jacob271 linked an issue Jan 16, 2023 that may be closed by this pull request
7 tasks
@jacob271 jacob271 marked this pull request as ready for review January 21, 2023 09:59
@jacob271
Copy link
Collaborator Author

PO @ylloop-368 has approved this PR

@IsThisTheCrustyCrab-was-taken
Copy link
Collaborator

IsThisTheCrustyCrab-was-taken commented Jan 23, 2023

please wait for Jacob to merge this!

code and everything looks cool and test etc run locally but there is one thing concerning functionality which I'm not sure about wether it's working as expected or not. If that is the case, this can be merged.

@jacob271 jacob271 merged commit 1457b4f into dev Jan 24, 2023
@jacob271 jacob271 deleted the feature/tf+-35-email-notifications branch January 24, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email notifications
2 participants