Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NATIVEINT=128 and update compat settings #77

Merged
merged 21 commits into from
Jan 29, 2025

Conversation

ArseniyKholod
Copy link
Collaborator

@ArseniyKholod ArseniyKholod commented Jan 24, 2025

I have introduced a new function OpenFHE.set_native_int! to use 128 bit native integers. This PR also updates compatibility settings for openfhe_julia_jll, openfhe_julia_int128_jll and minimal julia version to 1.10

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/OpenFHE.jl 100.00% <ø> (ø)
src/auxiliary.jl 100.00% <100.00%> (ø)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
src/OpenFHE.jl Outdated Show resolved Hide resolved
src/auxiliary.jl Outdated Show resolved Hide resolved
src/auxiliary.jl Outdated Show resolved Hide resolved
examples/simple_ckks_bootstrapping.jl Outdated Show resolved Hide resolved
test/test_auxiliary.jl Show resolved Hide resolved
@ArseniyKholod ArseniyKholod requested a review from sloede January 28, 2025 14:57
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready. Sorry, I missed a few places in the first review :-/

Project.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/OpenFHE.jl Outdated Show resolved Hide resolved
src/auxiliary.jl Outdated Show resolved Hide resolved
src/auxiliary.jl Outdated Show resolved Hide resolved
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ArseniyKholod ArseniyKholod merged commit bd5652c into hpsc-lab:main Jan 29, 2025
10 checks passed
@ArseniyKholod ArseniyKholod deleted the NATIVEINT branch January 29, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants