Add Mac OS X support to ndkBuild task #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `isUnix()` returns true for Mac systems, thus the check for Mac OS X must come before the check for Unix. The command line from Linux was copied to the Mac OS X case. Logger error messages were added to the Unix and unknown OS cases. Without these messages builds would fail with a non specific `execCommand == null!` message with little to indicate the source of the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
isUnix()returns true for Mac systems, thus the check for Mac OS X must come before the check for Unix.The command line from Linux was copied to the Mac OS X case and builds without issue.
Logger error messages were added to the Unix and unknown OS cases. Without these messages builds would fail with a non specific
execCommand == null!message with little to indicate the source of the error.