Fix IndexError when concentration is outside of EPA range #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e28eta
added a commit
to e28eta/pyportal-aqi
that referenced
this pull request
Mar 25, 2021
hrbonz/python-aqi#22 This started happening to me. PurpleAir thinks there's a bug or debris in the sensor I've chosen to display. 🤷♂️ Nothing I can do about the bad sensor, but this is greatly preferable to having the project crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hrbonz
Thanks for this great library.
I've found a minor edge case issue. I currently handle it in the calling code, but it would be nice to take care of it in the library.
Currently If pollutant concentration is outside of the lookup table range iaqi() function will crash with IndexError.
This PR fixes it. If the concentration is lower or higher than the range defined in the look up table, the function will return lowest or highest AQI value from the table accordingly.
Please let me know what you think about these changes.
Thanks.
Andrii