Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snazzy! This PR adds a new
Additional Names
field to various classes of data objects, which is written similarly to the "who (what)" format for contributions, and adds a neat box presenting those details on corresponding pages:Development:
User-visible changes:
Additional Names
field in much the same format as artist contributions - name, optionally plus annotation in parentheses.Track
) and directory fields, but otherwise should precede anything else (usually artists).Name: Savior of the Dreaming Dead (Blaze Remix)
,Annotation: beta title
. Cool!Who: Toby Fox
,What: arrangement
. It just doesn't come up nearly so often there, part becauseartist:foo-bar-baz
lets you get aroundFoo (Bar Baz)
type syntax already.Supporting internal changes:
additionalNameList
wiki property, plusisAdditionalNameList
validator - this titling is intended to be in line with e.g.isContributionList
,isAdditionalFileList
.parseContributors
function in yaml.js is generally refactored - the regular expression it works with is now on its own, since it's used by the newparseAdditionalNames
, and is touched up with named capturing groups, for better regex form.generatePageLayout
, much the same as cover art, and the automatically generated title heading (whether sticky or not) adapts to be interactive if that slot is filled.beforeHashLinkScrolls
- if any of its listeners returns false (exactly), the hash scrolling behavior is completely cancelled and it's up to a separate DOMclick
event listener to control click behavior (if custom behavior is desired at all).transformInline
for display purposes. This allows some ridiculosity as well as, for example, Markdown-formatted links or[[string]]
content tags in the annotation - but will cause some trouble for treating these as ordinary text data down the line (e.g. for sorting purposes). It's a low stakes place to mess around since most of the benefit of "additional names" is just getting to see them on the info page for the thing they belong to.