Remove scala version from default.properties #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froth
force-pushed
the
remove-scala-version-props
branch
from
3b381f9 to
a630ea3
Compare
rossabaker
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts published with higher scala minor versions are not downwards compatible. Therefore I believe it does not make a lot of sense to configure the scala version on template generation.
Compare https://github.com/http4s/http4s.g8/actions/runs/11562204886/job/32182864793#step:9:120
Additionally I hope this allows the steward to update the version for us.(Update: I think that won't work actually as this would need the top level sbt project upgraded to scala 2.13. That however makes sbt very angry because of the sbt-scripted plugin)