Merge pull request #131 from CampbellReid/npminstallfailurewindows

Added configuration to fix breaking change for latest node versions on windows cve-2024-27980
httptoolkit · Sep 25, 2024 · b0381b0 · b0381b0
2 parents d578829 + 33c85ce
commit b0381b0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/prepare.ts b/prepare.ts
@@ -29,7 +29,8 @@ const OVERRIDES_DIR = path.join(__dirname, 'overrides');
 
     await spawn(process.platform === 'win32' ? 'npm.cmd' : 'npm', ['ci', '--production'], {
         cwd: path.join(OVERRIDES_DIR, 'js'),
-        stdio: 'inherit'
+        stdio: 'inherit',
+        shell: process.platform === 'win32', // Required for .cmd files due to CVE-2024-27980
     });
 
     const files: Array<{