Actually check the theme extends field value

httptoolkit · Sep 9, 2024 · f5ec9ee · f5ec9ee
1 parent f545851
commit f5ec9ee
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/model/ui/ui-store.ts b/src/model/ui/ui-store.ts
@@ -157,7 +157,12 @@ export class UiStore {
         if (!themeData) throw new Error("Could not parse theme JSON");
 
         if (!themeData.name) throw new Error('Theme must contain a `name` field');
-        if (!themeData.extends) throw new Error('Theme must contain an `extends` field with a built-in theme name (dark/light/high-contrast)');
+        if (
+            !themeData.extends ||
+            Themes[themeData.extends as ThemeName] === undefined
+        ) {
+            throw new Error('Theme must contain an `extends` field with a built-in theme name (dark/light/high-contrast)');
+        }
 
         const baseTheme = Themes[themeData.extends];
         return {