Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace/app): supports new nas storage resource #5878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lance52259
Copy link
Collaborator

@Lance52259 Lance52259 commented Nov 18, 2024

What this PR does / why we need it:
Add new resource support, and names 'huaweicloud_workspace_app_nas_storage‘.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. Workspace APP supports new resource.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o workspace -f TestAccAppNasStorage_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccAppNasStorage_basic -timeout 360m -parallel 10
=== RUN   TestAccAppNasStorage_basic
=== PAUSE TestAccAppNasStorage_basic
=== CONT  TestAccAppNasStorage_basic
--- PASS: TestAccAppNasStorage_basic (8.79s)
PASS
coverage: 4.5% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 8.844s  coverage: 4.5% of statements in ./huaweicloud/services/workspace
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_worksapce_app_nas_storage branch 4 times, most recently from ed3743f to 525ca0d Compare November 19, 2024 03:29
@Lance52259
Copy link
Collaborator Author

./scripts/coverage.sh -o workspace -f TestAccAppNasStorage_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccAppNasStorage_basic -timeout 360m -parallel 10
=== RUN   TestAccAppNasStorage_basic
=== PAUSE TestAccAppNasStorage_basic
=== CONT  TestAccAppNasStorage_basic
--- PASS: TestAccAppNasStorage_basic (9.87s)
PASS
coverage: 5.8% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 9.919s  coverage: 5.8% of statements in ./huaweicloud/services/workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants