Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Helm chart and Kubernetes tutorial #72

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Feb 8, 2021

Related to #29

This adds the Helm chart as well as a tutorial for installing it as well as Prometheus and Grafana.

The dashboard file is pretty huge but here are the results from my test cluster.

scaphandre-kubernetes-dashboard

Create a configmap to store the Grafana dashboard.

kubectl create configmap scaphandre-dashboard \
--from-file=scaphandre-dashboard.json=docs_src/tutorials/grafana-kubernetes-dashboard.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the best way I could find to install the dashboard. Happy to move the files if they would be better somewhere else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could find a better location later. I guess this is fine for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I actually wanted to try loading the dashboard from Grafana Cloud here
https://grafana.com/grafana/dashboards/13845

But I ran into a bug with the Grafana chart.
grafana/helm-charts#200

@rossf7 rossf7 marked this pull request as ready for review February 8, 2021 16:19
@bpetit
Copy link
Contributor

bpetit commented Feb 8, 2021

Thanks a lot for the PR !
Don't worry about the failing test, my fix about that is waiting for another PR to be merged. I'll integrate those tests when I'll test the content of this one. This is great, thanks for your contribution :)

First we install Scaphandre which runs as a daemon set which creates a pod on
each node for collecting the metrics.

helm install scaphandre helm/scaphandre
Copy link
Contributor

@bpetit bpetit Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that suppose we rely on the local chart ? Maybe we should add the step to put the chart on the right location first ? (may seem obvious but this is to avoid confusing helm users used to download remote charts)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its using the local chart but that's not ideal.

The central Helm charts repo is now deprecated and not accepting new charts. https://github.com/helm/charts#helm-charts

The new pattern is to have a charts repo per org e.g. https://github.com/grafana/helm-charts and then link it to https://artifacthub.io/ for discoverability.

It should be possible to use something like GitHub Actions to push new versions of the chart to the repo. Happy to help with that if I can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as a first version.

We may create an FR after that to setup a helm chart repository for scaphandre.

@bpetit
Copy link
Contributor

bpetit commented Feb 12, 2021

I've tested it on a local cluster and the whole process works like a charm !

Thanks a lot. 😃

I'll integrate the recent fix I made for the CI job in a local branch and merge from there.

EDIT: I've just noticed that some targets of the prometheus deployment and down with "Get "http://192.168.1.31:9100/metrics": context deadline exceeded":

  • kubernetes-pods (0/1 up)
  • kubernetes-service-endpoints (3/4 up)
  • prometheus-pushgateway (0/1 up) ==> this one is expected as I didn't deploy the pushgateway

It is completely unrelated to scaphandre but if you have some information about that, I'd be interested to fix it in the process.

@bpetit bpetit merged commit 6105236 into hubblo-org:main Feb 12, 2021
@rossf7 rossf7 deleted the helm-chart branch September 18, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Previous releases
Development

Successfully merging this pull request may close these issues.

2 participants