John conroy/workspace detail auth #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
john-conroy
commented
Nov 16, 2023
john-conroy
commented
- Add authentication guard to workspace page.
john-conroy
changed the base branch from
main
to
john-conroy/workspace-detail
Co-authored-by: Nikolay Akhmetov <[email protected]>
john-conroy
added a commit
that referenced
this pull request
Nov 16, 2023
* Stub workspaces route * Add datasets table to workspaces page * Remove tsc-files * Add templates to workspace page * Add workspace summary * Add alert to top of workspace to remind users of session time * Add launch stop workspace to detail page * Add section headers * Add changelog * Fix pep8 * Fix changelog location * Increase template grid gap * Update changelog * Add todos * Update context/app/static/js/pages/Workspace/Workspace.tsx Co-authored-by: Nikolay Akhmetov <[email protected]> * Update context/app/static/js/shared-styles/cards/SelectableCard/SelectableCard.tsx Co-authored-by: Nikolay Akhmetov <[email protected]> * Update context/app/static/js/components/workspaces/hooks.ts Co-authored-by: Nikolay Akhmetov <[email protected]> * fix TS error - destructure after `undefined` check * John conroy/workspace detail auth (#3334) * Add workspace auth guard component * Use auth guard in workspaces pages * Add changelog * Update context/app/static/js/pages/Workspaces/Workspaces.jsx Co-authored-by: Nikolay Akhmetov <[email protected]> --------- Co-authored-by: John Conroy <[email protected]> Co-authored-by: Nikolay Akhmetov <[email protected]> --------- Co-authored-by: John Conroy <[email protected]> Co-authored-by: Nikolay Akhmetov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.