Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/HMP-457 Add workspace session renewal #3335

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

NickAkhmetov
Copy link
Collaborator

This PR adds an alert to the top of the workspaces list which allows for the renewal of active workspace sessions.

2023-11-20.renew.session.time.demo.mov

Ideas for additional improvements:

  • Adding a threshold time at which to start displaying that alert; right now, it displays this alert whenever any workspace is active
  • Linking to the running workspace's detail page as part of the alert

Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment of the text and button looks slightly off?

@NickAkhmetov
Copy link
Collaborator Author

The alignment of the text and button

This was due to the alert applying some additional padding around the action by default; it should be resolved now.

image
image

Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a threshold time at which to start displaying that alert; right now, it displays this alert whenever any workspace is active

I think this is okay for now. As users will be generally unfamiliar with the workspaces feature and its limitations we should make this information immediately available. Especially since opening a workspace takes you out of the portal.

Linking to the running workspace's detail page as part of the alert

All for it!

We might also want to think about adding a confirm dialog of some sort.

@NickAkhmetov
Copy link
Collaborator Author

Linking to the running workspace's detail page as part of the alert

Created HMP-514 to track this 👍🏻

We might also want to think about adding a confirm dialog of some sort.

We have HMP-502 reported for confirming deletion, so I'm a bit more hesitant with this since renewing isn't as destructive an action; introducing another confirmation for renewing the session might cause confirmation fatigue for users, which can cause accidental deletions due to user error/autopilot.

@NickAkhmetov NickAkhmetov changed the title NickAkhmetov/HMP-457 Add session renewal alert NickAkhmetov/HMP-457 Add workspace session renewal Nov 20, 2023
@NickAkhmetov NickAkhmetov merged commit 4cbbc8d into main Nov 20, 2023
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/hmp-457-session-refresh branch November 20, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants