-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NickAkhmetov/HMP-457 Add workspace session renewal #3335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of the text and button looks slightly off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a threshold time at which to start displaying that alert; right now, it displays this alert whenever any workspace is active
I think this is okay for now. As users will be generally unfamiliar with the workspaces feature and its limitations we should make this information immediately available. Especially since opening a workspace takes you out of the portal.
Linking to the running workspace's detail page as part of the alert
All for it!
We might also want to think about adding a confirm dialog of some sort.
Created HMP-514 to track this 👍🏻
We have HMP-502 reported for confirming deletion, so I'm a bit more hesitant with this since renewing isn't as destructive an action; introducing another confirmation for renewing the session might cause confirmation fatigue for users, which can cause accidental deletions due to user error/autopilot. |
This PR adds an alert to the top of the workspaces list which allows for the renewal of active workspace sessions.
2023-11-20.renew.session.time.demo.mov
Ideas for additional improvements: