NickAkhmetov/HMP-503-HOTFIX Fix workspace launch form lock #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
reviewed
Nov 21, 2023
|
The workspace passed to |
john-conroy
reviewed
Nov 21, 2023
|
I did notice the leading slash is missing, but it didn't seem to affect anything functionality-wise; for the sake of consistency, I will add logic to prepend a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR (#3336) introduced a regression where submitting the workspace launch dialog and having a validation failure occur locked the user out of continuing the workspace creation process until they reopened the dialog to reset form state.
This PR fixes this regression by using
isSubmitSuccessfulinstead ofisSubmittedto prevent queueing multiple workspace launches. The former is only toggled to true after validation succeeds, while the latter is set to true as soon as the user submits - even if the submit fails runtime validation.The original issue of duplicate workspace creation requests being created is still handled.
This PR also fixes an error finding the appropriate file path to provide when launching a workspace.