NickAkhmetov/HOTFIX Fix workspace launch error message display logic #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
reviewed
Nov 21, 2023
john-conroy
previously approved these changes
Nov 21, 2023
|
The Box didn't seem to have any noticeable effect besides constraining the |
john-conroy
approved these changes
Nov 21, 2023
NickAkhmetov
deleted the
nickakhmetov/hotfix-workspace-error-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls the workspace error message rendering logic outside of the condition that checks whether to display the protected datasets field in order to make other errors appear as expected.