NickAkhmetov/Fix publications page crashing when supporting json data is completely missing #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
reviewed
Jan 23, 2025
| @@ -30,7 +30,7 @@ function Publication({ publication, vignette_json }) { | |||
| const shouldDisplaySection = { | |||
| summary: true, | |||
| data: true, | |||
| visualizations: vignette_json?.vignettes.length > 0 && Boolean(Object.keys(vignette_json).length), | |||
| visualizations: vignette_json?.vignettes?.length > 0 && Boolean(Object.keys(vignette_json).length), | |||
There was a problem hiding this comment.
Suggested change
| visualizations: vignette_json?.vignettes?.length > 0 && Boolean(Object.keys(vignette_json).length), | |
| visualizations: vignette_json?.vignettes?.length > 0, |
Do we need the second condition?
There was a problem hiding this comment.
I'll double check with this change in place to make sure there are no unexpected regressions
There was a problem hiding this comment.
Yup, looks good/seems to work as expected with the second clause removed 👍🏻
Co-authored-by: John Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the condition for whether to display the visualizations section of the publication page so that the
.lengthproperty is not accidentally accessed from a missing/undefined vignettes list.Design Documentation/Original Tickets
Commit 5e5f263 introduced this issue while attempting to fix handling of empty vignette lists in present json files.
Testing
Manually tested locally with all publications on dev and test environments to confirm no crash occurs.
Screenshots/Video
N/A
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
Please specify any additional information or context relevant to this PR.