Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include latest commit hash in version info #609

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

GriffinRichards
Copy link
Collaborator

@GriffinRichards GriffinRichards commented Sep 9, 2024

It would sometimes be useful to get the hash of the latest commit Porymap was compiled with when getting bug information from users.

The displayed commit is only accurate once the Makefile is regenerated from porymap.pro and aboutporymap.cpp is recompiled, but this is also true for the version info (except it's mainwindow.cpp instead) so I'm not super worried about it.

about

  • Need to investigate what's happening in the GitHub actions for this (the commit hash for Linux and macOS was not in the repo, but that's because it was the hash of the pull request's test merge. This won't be a problem once it's actually merged)
  • Investigate why the windows static release build isn't getting a commit hash

@GriffinRichards
Copy link
Collaborator Author

Updated to...

  • Correctly find the latest commit hash on Windows
  • Add the Qt version Porymap was compiled with
  • Remove the changelog (I'm not sure this is the place to put it? It's a ton of information for what should be a concise window. It's still available via the documentation link, and via the update promoter when a new release is available, and if we really want the changelog always available in-app we could add a separate menu action for it).

@GriffinRichards GriffinRichards merged commit 9efbe53 into huderlem:master Dec 23, 2024
3 checks passed
@GriffinRichards GriffinRichards deleted the commit-version branch December 23, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant