Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for how to render fully transparent pixels #655

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

GriffinRichards
Copy link
Collaborator

Closes #654

The GBA will render fully transparent pixels using palette 0 color 0, but the Pokémon games overwrite palette 0 color 0 with black. One of the options for the new setting (and the default) will render transparent pixels as black, the other will render them with whatever is in color 0.

Additionally:

  • Adds a new setting for how to render the unused layer for metatiles. This was previously hard-coded to 0x3014 for Normal metatiles, and 0x0000 for Split/Covered metatiles.
  • Adds some warnings if the fieldmap properties (number of tiles, number of primary palettes, etc.) are given nonsense values
  • Disables the tileset divider, until the metatile images are actually separated by tileset.

@GriffinRichards GriffinRichards merged commit 7a36fcc into huderlem:master Dec 28, 2024
3 checks passed
@GriffinRichards GriffinRichards deleted the fix-transparency branch December 28, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porymap renders full transparency for Covered/Split incorrectly
1 participant