Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to be less eager to generate PDFs #36

Closed
wants to merge 1 commit into from
Closed

Conversation

payten
Copy link
Member

@payten payten commented Oct 3, 2016

If EAD XML mtime matches PDF mtime, assume they are a pair and we don't need to generate another PDF (previously the XML mtime had to be less than the PDF mtime).

I'm not sure if this is the fix!! But it's the only way I can see how this case might happen:

https://www.pivotaltracker.com/file_attachments/69631749/download?inline=true

What do you guys think?

@jambun
Copy link
Member

jambun commented Oct 3, 2016

wow - could this really be it?

@payten
Copy link
Member Author

payten commented Oct 3, 2016

Maybe :/ The thing is, if a record's mtime changes but the record stays the same, the XML will always update as there's a string in the EAD <creation>This finding aid was produced using ArchivesSpace on <date>2016-10-03 15:21:52 +1100</date>.</creation>. I couldn't see other ways the PDF could be exported and pushed up without the EAD XML changing.

@payten payten closed this Oct 12, 2016
@payten
Copy link
Member Author

payten commented Oct 12, 2016

This is not the fix! I think we need to see the logs to get a better picture of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants