possible fix for missing bib_udf_tb03 in reftracker response

hudmol · Nov 28, 2024 · 5d7ca76 · 5d7ca76
1 parent 9e032ae
commit 5d7ca76
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/backend/model/reftracker_client.rb b/backend/model/reftracker_client.rb
@@ -82,14 +82,14 @@ def self.manuscript_offers(page = 1, offer_number)
     # here's how accession.identifier looks in the db :(
     # ["moo",null,null,null]
     # NLA only uses id_0 so this works
-    offer_ids = offers.map{|offer| offer['bib_udf_tb03']}.select{|id| !id.empty?}.map{|id| '["' + id + '",null,null,null]'}.compact
+    offer_ids = offers.map{|offer| offer.fetch('bib_udf_tb03', '')}.select{|id| !id.empty?}.map{|id| '["' + id + '",null,null,null]'}.compact
 
     # find out which of the offer_ids already exist in AS
     found_ids = nil
     DB.open{ |db| found_ids = db[:accession].filter(:identifier => offer_ids).select(:identifier).map{|i| ASUtils.json_parse(i[:identifier]).first}}
 
     # then filter out the found ids, and any offers without an id
-    offers.select{|offer| !offer['bib_udf_tb03'].empty? && !found_ids.include?(offer['bib_udf_tb03'])}
+    offers.select{|offer| !offer.fetch('bib_udf_tb03', '').empty? && !found_ids.include?(offer['bib_udf_tb03'])}
       .map do |offer|
       offer['question_text_stripped'] = strip_markup(offer['question_text'])
       if offer['question_text_stripped'].length > 400