-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add callable object to convert frame into control_frame to reduce cpu memory usage. #10501
Conversation
Hi @chaowenguo. Could you share a usage example and some benchmarks/profiling to show the reduction in cpu memory usage? |
@hlky
You see the origin version require two long lists of PIL.Image before hand. one for frames and one for control_frames. Now the control_frames can be calculated on the fly which only need one list of PIL.Image before hand. so the cpu memory usage can be half compare to the original version |
Co-authored-by: hlky <[email protected]>
@hlky i already update the source code as your suggestion, can you review it again? |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@hlky