-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPU adaption for RMSNorm #10534
NPU adaption for RMSNorm #10534
Conversation
@sayakpaul Please take a look at this PR, thanks for your help! |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leisuzz. Would be nice to check the numerical accuracy of this when we start adding NPU to CI.
Hi @hlky, I've already checked the accuracy of the npu RMSnorm. It didn't affect the accuracy of the result (loss are the same between the two methods in NPU). |
That's great, thanks for checking @leisuzz. |
What does this PR do?
Added NPU RMSNorm function to get the better performance for NPU devices
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.